weather: show a moon glyph on clear nights - #13
Open
dharmapoudel wants to merge 1 commit into
Open
dharmapoudel wants to merge 1 commit into
dharmapoudel wants to merge 1 commit into
Conversation
The current-conditions glyph always showed the sun for WMO code 0, even at night. Request `is_day` from open-meteo and render the moon glyph when it is night; the label stays "clear" and the daily tiles are untouched (day aggregates). A missing `is_day` field falls back to the old daytime behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current-conditions glyph always showed the sun for WMO code 0, even in the middle of the night.
What this does
is_dayfrom open-meteo alongside the existingcurrentfields.wmo()takes anightflag: code 0 at night renders the moon glyph instead of the sun. The label stays "clear" and the daily forecast tiles are untouched (they are day aggregates).is_dayfield falls back to the old daytime behavior, so nothing breaks if the API shape ever changes.Files
packages/webapps/catalog/weather/src/App.tsx--isDayon the forecast type,is_dayin the request params and response parsing, night flag plumbed fromForecastViewintowmo().Validation
tsc --noEmitclean,vite buildclean.is_daymissing/0/1 edge cases -- all pass.