system_for_each must be able to accept Entity as a component#13
Merged
JohanNorberg merged 1 commit intomainfrom Nov 23, 2025
Merged
system_for_each must be able to accept Entity as a component#13JohanNorberg merged 1 commit intomainfrom
JohanNorberg merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for accepting Entity as a component parameter in system_for_each macro-generated functions, enabling systems to access entity identifiers during iteration. This aligns the macro with the existing ECS query system where Entity is already treated as a special queryable component type.
Key changes:
- Extended the
system_for_eachmacro to recognizeEntityas a valid component type - Added comprehensive integration tests demonstrating entity-based filtering and destruction patterns
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| zero_ecs_macros/src/system_for_each_impl.rs | Adds "Entity" to the set of recognized component types for system parameter validation |
| zero_ecs_testbed/src/integration_tests/test_simple.rs | Adds test demonstrating Entity parameter usage for selective entity destruction based on component values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.