refactor: use intersection observer and website config#134
Merged
JohnsonMao merged 2 commits intodevfrom Apr 5, 2025
Merged
Conversation
- Move IntersectionObserver initialization to useEffect - Properly disconnect and nullify observer instances - Fix array element filtering in setInternalElementRef - Update tests to reflect new observer behavior
Move scattered website configuration variables from metadata.ts into a single WEBSITE_CONFIGS object in constants/index.ts for better maintainability.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #134 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 539 542 +3
Branches 93 93
=========================================
+ Hits 539 542 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.