Replace string_tree with String for message buffering (#20) - #27
Merged
JonasGruenwald merged 1 commit intoMar 20, 2026
Merged
Conversation
Contributor
Author
|
The benchmark module used for testing was excluded from this PR to keep it clean. Results are in #20. Happy to provide the module separately if needed. |
Owner
|
Thanks! This looks good to me, seems like the CI issue is unrelated to these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the
string_treebuffer with plainStringin the chrome actor'sprocess_port_message, as discussed in #20.Ran some benchmarks and String came out faster in every scenario even repeated buffering where
string_treeshould theoretically have the advantage. The biggest difference was on large messages (~100KB) where String was about 3x faster.The code also gets simpler since we no longer need
string_treein the hot path.Closes #20