More Bug Fixes + Extra Convars - #348
Open
heckkkkk-jpg wants to merge 1 commit into
Open
Conversation
heckkkkk-jpg
commented
Sep 1, 2026
heckkkkk-jpg
commented
Contributor
- Fixed Tosugeki Sound Volume.
- Added Dive.Tosugeki into Sounds_Misc.
- -Added a janky method to prevent disarming on certain npcs IE Turrets,Helicopter, etc.
- Added FallLock Convar. -Added Cloth.Fall on balance pipe.
- Fixed crouch jumping when on a swingbar.
- Fixed Stop Sound Convar.
- Renamed "Beatrun_StopDeathSound" to "Beatrun_Death_StopSound"
- Fixed Tosugeki Sound Volume. - Added Dive.Tosugeki into Sounds_Misc. -Added a janky method to prevent disarming on certain npcs IE Turrets,Helicopter, etc. - Added FallLock Convar. -Added Cloth.Fall on balance pipe. - Fixed crouch jumping when on a swingbar. - Fixed Stop Sound Convar. - Renamed "Beatrun_StopDeathSound" to "Beatrun_Death_StopSound"
JonnyBro
requested changes
Sep 1, 2026
| @@ -1,7 +1,9 @@ | |||
| local stopsound = CreateClientConVar("Beatrun_StopDeathSound", "1", true, false) | |||
| local stopsound = CreateClientConVar("Beatrun_Death_StopSound", "0", true, false) | |||
Owner
There was a problem hiding this comment.
Why the rename? I get the change to "0" by default tho
|
|
||
| net.Receive("DeathStopSound", function() | ||
| if stopsound:GetBool() then | ||
| return |
Owner
There was a problem hiding this comment.
Could just do
if not stopsound:GetBool() then return end
...| end) | ||
|
|
||
| hook.Add("InputMouseApply", "FallLock", function(cmd, x, y, ang) | ||
| local BRFallLock = CreateClientConVar("Beatrun_FallLock", "1", true, false) |
Owner
There was a problem hiding this comment.
Creating a convar inside a hook is a bad idea
|
|
||
| -- Not the best method to filter out imcompatible NPC rigs. | ||
| -- Feel free to replace this with something less janky. | ||
| local IgnoreDisarm = { |
Owner
There was a problem hiding this comment.
Please use glualint for this project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.