Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes waxy.Point hashable in the Python API, enabling its use in hashed containers like set/dict, and adds a basic regression test plus a typing stub update.
Changes:
- Add a
Point.__hash__implementation in the Rust/PyO3 binding. - Add a Python test validating hashing and set deduplication for
Point. - Update the Python type stubs to declare
Point.__hash__.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_geometry.py | Adds a new test asserting Point hashing works and supports set deduplication. |
| src/geometry.rs | Implements Point.__hash__ for the PyO3-exposed Point type. |
| python/waxy/init.pyi | Adds __hash__ to the Point stub to reflect the new runtime behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.