Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Python-side value equality support for waxy.Style so ==/!= compare style contents instead of object identity.
Changes:
- Implement
Style.__eq__in the Rust#[pyclass]wrapper by comparing the underlyingtaffy::Style. - Add test coverage for
Styleequality (default, same fields, differing fields, non-Stylecomparisons). - Update the Python stub (
.pyi) and changelog to reflect the new API behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_style.py | Adds unit tests validating Style equality/inequality behavior. |
| src/style.rs | Implements __eq__ for Style by delegating to taffy::Style equality. |
| python/waxy/init.pyi | Exposes Style.__eq__ in type stubs. |
| docs/changelog.md | Documents the new Style equality feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.