Add NOTICE and record the embedded specification bundle#7
Merged
Conversation
The repository asserted no copyright owner: `LICENSE` is the unmodified Apache-2.0 text, whose appendix is a template rather than a field to fill. Add a `NOTICE` naming Brian Jin and leave `LICENSE` byte-identical so automated license scanners keep reporting a clean Apache-2.0 match. `THIRD_PARTY_NOTICES` credited the four Go modules but not the specification bundle, even though `internal/artifacts/artifacts.go` embeds 51 files from judgment-pack-spec into every binary. That material is Apache-2.0 from a separate project and appears in neither go.mod nor go.sum, so the previous Go-modules-only framing omitted the one attribution Apache-2.0 section 4 actually requires. Ship `NOTICE` in the release archives, and add it to the release workflow's timestamp-normalization list. GoReleaser copies each extra file's filesystem mtime into the archive and `.goreleaser.yml` sets no `info:` block, so a file omitted from that `touch` lands with checkout time and silently breaks byte-reproducibility -- checksums and attestation still cover whatever bytes were produced. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Brian Jin <35789537+kikashy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two attribution gaps, one legal and one silent.
No copyright owner was asserted anywhere.
LICENSEis the unmodified Apache-2.0 text — its appendix is a template for marking your own files, not a field to fill in. The repo creditedDoug ClarkandThe Go AuthorsinTHIRD_PARTY_NOTICESbut nobody for its own ~3,900 lines.THIRD_PARTY_NOTICESomitted the specification bundle.internal/artifacts/artifacts.go:18is//go:embed jps— 51 files fromjudgment-pack-specare compiled into every binary. That is Apache-2.0 material from a separate project, it appears in neithergo.modnorgo.sum, and it is the one attribution Apache-2.0 §4 actually requires. The Go-modules-only framing missed it entirely.What
NOTICE— names Brian Jin, carries the bubbled-up attribution for the embedded bundleTHIRD_PARTY_NOTICES— restructured into embedded artifacts + Go modules, with the spec bundle listed firstLICENSE— untouched, byte-identical to canonical (sha256cfc7749b…), so license scanners keep reporting a clean Apache-2.0 match.goreleaser.yml/release.yml/README.md— shipNOTICEin the archives and describe it accuratelyCHANGELOG.md— corrects the stale "LICENSE copyright-owner line not yet filled in" entry, which would have led someone to editLICENSEincorrectlyThe non-obvious bit
NOTICEalso had to go into the release workflow'stouchlist, not just.goreleaser.yml. GoReleaser stamps each extra archive member with its filesystem mtime unlessarchives.files[].infois set — and noinfo:block exists, so thattouchis the repo's only reproducibility mechanism. A file infiles:but not intouchlands with checkout time, differing on every run. It fails silently:checksums.txtand the attestation still cover whatever was produced.Verified
Snapshot build (
goreleaser release --snapshot):!= 7gate atrelease.yml:225holdsNOTICEpresent in all 6 archives2026-07-23 16:31:54in every archive, identical toLICENSE/README.md/THIRD_PARTY_NOTICESand equal toSOURCE_DATE_EPOCHgo test ./...,go vet ./...,goreleaser checkall clean.🤖 Generated with Claude Code