BE-9645 : Add challengeCompleted and accountDetailsUpdated to receipt response schema (added in Api-Version 6.24)#205
Merged
Stuart-Baillie merged 9 commits intomasterfrom Mar 26, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the .NET SDK’s receipt response models/tests to reflect newly returned API fields, and bumps the default API version used by requests.
Changes:
- Added
ChallengeCompletedtoThreeDSecureReceiptModelandAccountDetailsUpdatedtoNetworkTokenisationDetailsModel. - Bumped default API version header value to
6.25and updated/expanded tests accordingly. - Updated dependency lock files (notably Newtonsoft.Json to
13.0.4) and made small test/sample cleanups.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| JudoPayDotNet/Models/ThreeDSecureReceiptModel.cs | Adds ChallengeCompleted field to 3DS receipt model. |
| JudoPayDotNet/Models/NetworkTokenisationDetailsModel.cs | Adds AccountDetailsUpdated field to network tokenisation details. |
| JudoPayDotNet/Http/VersioningHandler.cs | Bumps default api-version header to 6.25. |
| JudoPayDotNetTests/Clients/PaymentTests.cs | Adds mapping tests for new receipt fields and refactors expiry constants. |
| JudoPayDotNetTests/Clients/*.cs | Refactors repeated expiry date literals and minor assertion improvements. |
| JudoPayDotNetIntegrationTests/*.cs | Adds extra null assertions in integration tests. |
| CHANGELOG.md | Adds a 5.3 section mentioning the API version bump. |
| **/packages.lock.json (multiple) | Dependency lock updates (Newtonsoft.Json 13.0.4, HtmlAgilityPack 1.12.4, etc.). |
| JudoPayDotNetCoreSampleApp/JudoPayDotNetCoreSampleApp.cs | Makes the sample app class static. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
krishna-thapa
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.