Conversation
…ocolStatsService (#285) * chore(stats): drop JuiceDollar bridge-volume leg from ProtocolStatsService The JuiceDollar Ponder stack is being retired, so the 24h stablecoin bridge volume query would fail permanently and log a warning on every stats request while contributing a silent 0. Bridge volume is now the LDS Ponder leg alone. Removes the orphaned JUICEDOLLAR_PONDER_URL env example and updates the protocol stats table in the README. Deploy configs live in a separate repo and are handled outside this change. * test(stats): pin LDS_PONDER_URL in the bridge volume test The URL assertion relied on the hardcoded fallback, so an exported LDS_PONDER_URL in the shell made the test fail despite correct behaviour. * test(stats): make the bridge volume mock answer the JuiceDollar query The shared mock returned no bridgeVolumeStats field, so the old JuiceDollar leg would have contributed 0 and the volume assertion stayed green against the pre-change service. The mock now answers that query with 5 JUSD, which makes the old code report 12 instead of 7. * test(stats): reject unexpected Ponder queries in the bridge volume mock The catch-all branch answered any query with the LDS payload, so a malformed query would still have produced a green test. The mock now throws on anything that is neither query, and the LDS call is asserted positively. * test(stats): assert the LDS query without pinning its formatting The substring assertion matched the exact query literal, so reformatting the production query would have broken the test without a behaviour change. * test(stats): tolerate whitespace around the chainId key in the query assertion * test(stats): anchor the chainId assertion on a word boundary
Danswar
self-requested a review
August 21, 2026 19:29
Danswar
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist