Require XML.jl 0.4 only (follow-up to #71)#73
Draft
mathieu17g wants to merge 1 commit into
Draft
Conversation
Variant of the 0.4 migration without the 0.3 compatibility layer: the two private child-access helpers are replaced by XML.jl 0.4's exported `elements`/`eachelement` (added in 0.4 for exactly this whitespace-explicit access pattern). The recursive element walker stays: no XML.jl reader iterates a whole tree in document order. Compat narrowed to "0.4". Assisted-by: Claude (Anthropic)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 81.90% 81.81% -0.09%
==========================================
Files 6 6
Lines 431 429 -2
==========================================
- Hits 353 351 -2
Misses 78 78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #71, this parks the
XML = "0.4"-only variant somewhere more durable than my fork: the two private child-access helpers become 0.4's exportedelements/eachelement(the recursive walker stays), and compat narrows to"0.4".Rebased onto master after the #71 squash, so the diff is exactly the 0.4-only delta; the frozen reference branches from the #71 discussion stay untouched at mathieu17g/PhotometricFilters.jl@xml-v04-compat...xml-v04-only.
The full test suite passes on this branch (1294/1294, doctests included).
Opened as a draft — it's yours to merge whenever you decide to drop 0.3; dropping support is usually minor-release material since it narrows the resolver for downstream environments.