crossover:v0; first simple version for feedback#56
Draft
charles-vzf wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
added 4 commits
June 8, 2026 08:54
Run effective bounds on device via row kernels (CSR/ELL) with atomic bound merging, keep CSC on CPU, and vectorize crossover_n_changed so docs and CI GPU tutorial examples no longer hit scalar indexing errors.
Buildkite runs cuSPARSE CuSparseMatrixCSR solves; dispatch crossover row kernels via a thin wrapper in CoolPDLPCUDAExt.
Add unit tests for implied-bound branches, backend agreement, pipeline consistency, and optional CUDA coverage. Replace in-kernel atomic bound updates with row scan plus host merge so CuSparseMatrixCSR matches CSC/JL results on equality rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add V1 post-solve crossover (threshold snap + implied bounds) Refs #13
Post-OPTIMAL crossover for PDLP: snap primal coordinates near finite box bounds, tighten implied bounds from equality rows, rollback if KKT residuals regress. Controlled by CrossoverParameters on Algorithm (enabled by default).
V1 is not a basic-vertex crossover (unlike cuOpt): it helps near-bound / implied-bound cases (e.g. toy_lp) but is usually a no-op when variables stay strictly interior. Lightweight first step toward MIP-ready solutions.
Also realized a small bench compared to cuopt:
I am planning a more advanced version cuopt-like after feedbacks