Issue #399#425
Open
franzi448 wants to merge 6 commits into
Open
Conversation
Member
|
@franzi448 this is not correct. You will need to consult this page to properly make package extensions work in Julia 1.9: https://pkgdocs.julialang.org/v1/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions) there is no |
Contributor
Author
|
Sorry, thank you for the link! I tried again and hope this time it is right. |
Member
|
I am sorry for being late here. Thanks for your continued effort! Perhaps you can work on making sure all tests pass? Both the formal tests and the documentation build. It is much better for me to review a PR whose tests are passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 'Requires' and bump to 1.9