Generalize utility function methods#106
Open
simsurace wants to merge 2 commits intoJuliaDynamics:masterfrom
Open
Generalize utility function methods#106simsurace wants to merge 2 commits intoJuliaDynamics:masterfrom
simsurace wants to merge 2 commits intoJuliaDynamics:masterfrom
Conversation
asinghvi17
approved these changes
May 2, 2026
Member
asinghvi17
left a comment
asinghvi17
left a comment
There was a problem hiding this comment.
Seems reasonable to me, but I'll leave this open for comments for a bit
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ostensibly, since
OSMGraphinstances can be constructed that have index or node id types different from the default, it should also be possible to use the utilities with the corresponding types.Maybe they could be generalized even further (e.g. to
IntegerandUnion{Integer, String}), since theDictaccess will promote them if possible.