fix CI: isdefined -> isassigned and add Dependabot#120
Merged
asinghvi17 merged 2 commits intomasterfrom May 2, 2026
Merged
Conversation
Julia 1.11+ changed isdefined(::Vector, i) to only check bounds, not
element initialization (Vectors now back onto Memory{T}). Use isassigned
to preserve the original "is this slot populated?" semantics. Without
this, osm_subgraph populated osg.dijkstra_states even when g had all
undef entries, causing UndefRefError when comparing in tests.
Weekly grouped updates so all action bumps land in one PR.
asinghvi17
changed the title
isdefined -> isassigned and add Dependabot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
osm_subgraphand the Subgraph testset relied onisdefined(::Vector, i)to detect populated dijkstra slots. Julia 1.11+ changed that to a bounds-only check (Vectors back ontoMemory{T}now), so it always returnstruefor valid indices. Switched toisassigned, which preserves the original semantics. Without this, the Subgraph tests have been failing on Julia 1 (stable) since the runner-level "Set up job" failures were fixed in CI: Update some external GitHub Actions #118.github-actionsso future action-version drift gets caught before it bites CI.Verified
Out of scope
test/download.jl:47(SystemError: opening file "map.json": Invalid argument). Not addressed here — file-path/locking on Windows, unrelated to the Julia regression. Will pop out on its own once stable Julia 1 turns green.Test plan
🤖 Generated with Claude Code