Replace getkey with get#95
Merged
asinghvi17 merged 3 commits intoJuliaDynamics:masterfrom May 2, 2026
Merged
Conversation
jarodlam
approved these changes
Jun 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 80.10% 80.10%
=======================================
Files 15 15
Lines 1141 1141
=======================================
Hits 914 914
Misses 227 227
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Bump |
asinghvi17
approved these changes
May 2, 2026
Member
asinghvi17
left a comment
asinghvi17
left a comment
There was a problem hiding this comment.
Thanks, as this was approved by previous maintainers it seems fine to merge
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
=========================================
Coverage ? 83.43%
=========================================
Files ? 14
Lines ? 1141
Branches ? 0
=========================================
Hits ? 952
Misses ? 189
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates one dictionary lookup in the case where highway_type is a key in
DEFAULT_XXX, and avoids the use ofgetkey, an obscure function that is less likely to be as well maintained or efficiently implemented asget.