Skip to content

Refactor factorization in the presence of missing data#49

Merged
juliohm merged 3 commits into
mainfrom
factorization-missing-data
Jul 7, 2026
Merged

Refactor factorization in the presence of missing data#49
juliohm merged 3 commits into
mainfrom
factorization-missing-data

Conversation

@juliohm

@juliohm juliohm commented Jul 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov-commenter

codecov-commenter commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.62%. Comparing base (d13f305) to head (7d8d33f).

Files with missing lines Patch % Lines
src/krig.jl 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   95.81%   95.62%   -0.19%     
==========================================
  Files          11       11              
  Lines         549      549              
==========================================
- Hits          526      525       -1     
- Misses         23       24       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Benchmark Results (Julia v1)

Time benchmarks
main 7d8d33f... main / 7d8d33f...
kriging/full 29.1 ± 0.57 ms 30.3 ± 0.55 ms 0.961 ± 0.026
kriging/miss 30.5 ± 0.47 ms 0.0682 ± 0.00058 s 0.446 ± 0.0079
time_to_load 1.99 ± 0.00084 s 1.98 ± 0.011 s 1 ± 0.0058
Memory benchmarks
main 7d8d33f... main / 7d8d33f...
kriging/full 0.45 M allocs: 0.0382 GB 0.47 M allocs: 0.0393 GB 0.973
kriging/miss 0.51 M allocs: 0.0399 GB 0.62 M allocs: 0.0479 GB 0.832
time_to_load 0.149 k allocs: 11.1 kB 0.149 k allocs: 11.1 kB 1

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Benchmark Results (Julia vlts)

Time benchmarks
main 7d8d33f... main / 7d8d33f...
kriging/full 0.0478 ± 0.0016 s 0.0522 ± 0.00067 s 0.917 ± 0.033
kriging/miss 0.0486 ± 0.001 s 0.0902 ± 0.0018 s 0.539 ± 0.016
time_to_load 2.15 ± 0.071 s 2.14 ± 0.026 s 1.01 ± 0.036
Memory benchmarks
main 7d8d33f... main / 7d8d33f...
kriging/full 0.44 M allocs: 0.0444 GB 0.44 M allocs: 0.0444 GB 1
kriging/miss 0.45 M allocs: 0.0447 GB 0.51 M allocs: 0.0516 GB 0.867
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@juliohm
juliohm merged commit 3705ac7 into main Jul 7, 2026
8 checks passed
@juliohm
juliohm deleted the factorization-missing-data branch July 7, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants