Update is_binaryop_nestable to retain the same meaning on JuliaSyntax@1#1193
Closed
penelopeysm wants to merge 1 commit into
Closed
Update is_binaryop_nestable to retain the same meaning on JuliaSyntax@1#1193penelopeysm wants to merge 1 commit into
penelopeysm wants to merge 1 commit into
Conversation
Contributor
Member
Author
|
This broke #911 [6](https://github.com/JuliaEditorSupport/JuliaFormatter.jl/actions/runs/28249996807/job/83698800525?pr=1193#step:6:149)
Formatting output did not match expected value.
Expected:
@testset begin
DynamicPPL.assume(
::Random.AbstractRNG, ::DynamicPPL.Sampler{MyEmptyAlg}, dist, vn, vi
) = DynamicPPL.assume(dist, vn, vi)
end
Got:
@testset begin
DynamicPPL.assume(::Random.AbstractRNG, ::DynamicPPL.Sampler{MyEmptyAlg}, dist, vn, vi) = DynamicPPL.assume(
dist, vn, vi
)
end
Repro:
s = "@testset begin\n DynamicPPL.assume(::Random.AbstractRNG, ::DynamicPPL.Sampler{MyEmptyAlg}, dist, vn, vi) = DynamicPPL.assume(\n dist, vn, vi\n )\nend\n"
format_text(s, BlueStyle())
911: Test Failed at /home/runner/work/JuliaFormatter.jl/JuliaFormatter.jl/src/internal/utils.jl:211 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1013
f() = ...used to returntrueforis_assignment(cst)with JuliaSyntax@0.4But it's different in JuliaSyntax v1
which causes
is_assignment()to return false. The solution is to adddefines_function(cst)to catch this case.