Skip to content

Implement a 2-arg Base.hash() instead of 1-arg#27

Merged
t-bltg merged 2 commits into
JuliaGraphics:masterfrom
JamesWrigley:hash
Nov 4, 2025
Merged

Implement a 2-arg Base.hash() instead of 1-arg#27
t-bltg merged 2 commits into
JuliaGraphics:masterfrom
JamesWrigley:hash

Conversation

@JamesWrigley
Copy link
Copy Markdown
Contributor

This prevents a ton of invalidations:

 inserting hash(x::Measures.Length{U}) where U @ Measures ~/.julia/packages/Measures/PKOxJ/src/length.jl:19 invalidated:                                                                                                                       
   backedges: 1: superseding hash(x) @ Base hashing.jl:28 with MethodInstance for hash(::Any) (1202 children)

Discovered when looking into JuliaLang/IJulia.jl#1208.

CC @t-bltg, this is a dependency of Plots.jl.

@t-bltg t-bltg merged commit ee3cb3a into JuliaGraphics:master Nov 4, 2025
3 checks passed
@JamesWrigley JamesWrigley deleted the hash branch November 4, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants