Draft
Conversation
* init broadcasting changes * broadasting almost works * error on user defined functions * support scalar broadcasting * asd * better type promotion * fix floaty unary ops * use optimized square and reciprocal calls given 2 and -1 literals * start tests * add allowscalar and allowdouble * ban promotion to all wider types * working on tests * force NDArray type param for dim to be Int64 * tests up to GEMM pass * up to unary_ops pass * unary reductions pass tests * binops pass except things with NaN * all tests pass * add short hands to copy to and from Julia array * tests for scalars * fix tests i broke * stuff * fix some things * all tests pass * remove if-else * separate out promotion logic * add lcm, gcd, negation tests --------- Co-authored-by: krasow <krasow@u.northwestern.edu>
Co-authored-by: krasow <krasow@u.northwestern.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals: