This repository was archived by the owner on Dec 10, 2023. It is now read-only.
Fix Dekker multiplication for subnormals/overflow and add exhaustive tests#32
Open
Fix Dekker multiplication for subnormals/overflow and add exhaustive tests#32
Conversation
Member
Author
|
Didn't realize how many julia versions this still supports. If you want to continue to do so, I will need to revise this. Alternatively we could bump the requirement. |
Collaborator
|
I would say that we should bump the requirement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main virtue of this PR is that it adds exhaustive tests of
Float16. These might be useful even after switching to an fma-based algorithm. They take too long to run by default, but it seems useful to have them. I will have a similar PR for Base's TwicePrecision utilities, but no reason not to also have them here.Built on top of #31.