compat: widen OrderedCollections to "1, 2" - #72
Merged
Conversation
DataStructures 0.19.6 widened its own bound to OrderedCollections "1.1, 2" (0.19.5 pinned it at 1.1.0), which is what made this compat widening unsatisfiable before — the reason CompatHelper PRs #58 (closed) and #67 could never resolve, not a problem in our code. Resolves cleanly now: OrderedCollections 2.0.1 + DataStructures 0.19.6. Suite 935/935 locally on that resolution, which is the real gate here — OrderedCollections 2.0 is a major bump and supplies LittleDict, used in the protocol layer. Supersedes #67 (its merge ref predates #68, the actions/checkout v7 bump). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #67 (and the earlier, closed #58), which could never resolve.
Why it works now
DataStructurescappedOrderedCollectionsat1.1.0through 0.19.5, so widening our bound was unsatisfiable — that is why CompatHelper's PRs failed withUnsatisfiable requirements detected for OrderedCollections, not anything in our code. DataStructures 0.19.6 widened its own bound to"1.1, 2", which unblocks it. Our existingDataStructures = "0.18.20, 0.19"already admits 0.19.6.Resolves cleanly:
Verification
The resolve is not the interesting part — the suite is.
OrderedCollections2.0 is a major bump and it suppliesLittleDict, which this package uses in the protocol layer, so the test suite is the real gate:main).mainfor an unrelated reason and four of its steps could not fail at all.Purely additive for downstream resolution — it widens a bound rather than narrowing one, so it is non-breaking for the registered reverse dependencies.
🤖 Generated with Claude Code