test/ctors: introspect on the bare DataType, construct on the UnionAll#66
Open
Keno wants to merge 1 commit into
Open
test/ctors: introspect on the bare DataType, construct on the UnionAll#66Keno wants to merge 1 commit into
Keno wants to merge 1 commit into
Conversation
`test_typeparams` was rebinding `Model` to `coretype(Model)` and then calling
`Model(args...)`, which only dispatched because `Type{Foo{T,V}} <: Type{Foo}`
held under the old free-TypeVar subtype rules. JuliaLang/julia#61876 removes
that subtype, and the `@snn_kw`-generated kwarg constructor (defined only on
`Type{Foo}`) no longer matches.
Keep the original `Model` UnionAll for construction, and use a local DataType
binding only where field introspection is needed.
The behavior of free TypeVars in subtyping was previously undefined (in effect
a bug); JuliaLang/julia#61876 makes them well-defined singleton identities,
which is what surfaces this latent issue.
This change was AI-generated and should be reviewed carefully before merging.
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_typeparamswas rebindingModeltocoretype(Model)and then callingModel(args...), which only dispatched becauseType{Foo{T,V}} <: Type{Foo}held under the old free-TypeVar subtype rules. JuliaLang/julia#61876 removes that subtype, and the@snn_kw-generated kwarg constructor (defined only onType{Foo}) no longer matches.Keep the original
ModelUnionAll for construction, and use a local DataType binding only where field introspection is needed.The behavior of free TypeVars in subtyping was previously undefined (in effect a bug); JuliaLang/julia#61876 makes them well-defined singleton identities, which is what surfaces this latent issue.
This change was AI-generated and should be reviewed carefully before merging.