has_persistent_tasks: use add not dev#339
has_persistent_tasks: use add not dev#339asinghvi17 wants to merge 1 commit intoJuliaTesting:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
==========================================
- Coverage 86.91% 79.48% -7.44%
==========================================
Files 11 11
Lines 512 502 -10
==========================================
- Hits 445 399 -46
- Misses 67 103 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I am not quite sure if I understand the problem you are trying to fix. Could you create some minimal example with some detailed instructions on how to get to an error that is fixed by this PR? (I haven't yoused the sources feature myself yet, so I'll need a helping hand for setting up a minimal example) As a side note: CI seems to be unhappy about this change. Julia version pre 1.10 just succeed because they skip the persistent task set in their testsuite |
|
@asinghvi17 are you still interested in completing this PR? If so, could you please address @lgoettgens questions? |
|
Yeah I should revive this. The issue here is that if you have a package in a monorepo but you install it via Pkg, then Pkg will just get the relevant subdir, not the full monorepo. Then, if your package has sources, and you try to The idea here is to |
In situations where the targeted package has a
sourcessection this will try to dev the package. Pkg then tries to find the packages indicated in sources, which will all be local paths assuming a monorepo structure, except those don't exist - because this is the stripped tarball you get from a Pkg server and not the full repo structure.Using
addshould "just fix" that.