fix!: activate undocumented names test for v1 release#368
Open
gdalle wants to merge 6 commits intoJuliaTesting:masterfrom
Open
fix!: activate undocumented names test for v1 release#368gdalle wants to merge 6 commits intoJuliaTesting:masterfrom
gdalle wants to merge 6 commits intoJuliaTesting:masterfrom
Conversation
gdalle
changed the title
Contributor
Author
|
Ironically, Aqua itself doesn't pass its own test ^^ |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
==========================================
- Coverage 86.77% 79.68% -7.09%
==========================================
Files 11 11
Lines 514 502 -12
==========================================
- Hits 446 400 -46
- Misses 68 102 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@fingolfin this one should be relatively uncontroversial? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Breaking change
The new test detecting undocumented public names was added in #313 and left off by default. Since we're heading towards a breaking v1, it is time to switch it on by default.
There was a flaw in the existing implementation: undocumented private submodules were counted as undocumented names. I slightly modified
walkmodulesto filter those out when runningtest_undocumented_names.