Add contrail-service-checks charm

[n-pochet]

• Add reactive contrail-service-checks charm
• Add unit and functional tests

[Andrey-mp]

Hi, can you please describe what is it, why this is needed and why it's implemented in such manner?

I mean:

• why this is separate charm and is not included into analytics?
• why analytics api ip is added into config instead of adding relation to analytics charm?
• why keystone creds are added to config instead of adding relation to keystone?

[n-pochet]

Hi @Andrey-mp,

• This is a separate charm as it is not directly related to contrail analytics. The advantage is that you can modify this charm without having to release a new version of contrail-analytics.
• This is already a config option of the contrail-controller charm. I did not see the advantage of creating a new relation just for this parameter.
• The keystone creds can be added in two ways:
  • In the config option
  • Through a relation with keystone. This one being preferred .

[Andrey-mp]

if this charm is not related to analytics then it's better to place it separately. But I would prefer to have this functionality inside analytics charm.

[aieri]

Hi @Andrey-mp, has there been any progress around the topic of exporting Contrail alerts to Nagios (either within the analytics charm or separately)?

[Andrey-mp]

Hi @aieri I don't see any activity here. I left my suggestions above.