perf: add LRU chunk-file cache to findEntity#1199
Open
jmountifield wants to merge 1 commit intomainfrom
Open
Conversation
When entities are flushed to disk, each findEntity() call reads and parses an entire JSON chunk file (~500 entities) with no caching. Repeated calls for entities in the same chunk file re-read the file every time. Add a bounded LRU cache (max 50 files) over chunk-file reads in FileSystemGraphObjectStore.findEntity(). Second and subsequent lookups for entities in the same chunk file are served from memory. Cache is invalidated on flushEntitiesToDisk() to prevent stale reads. Zero API changes — fully backwards compatible. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
VDubber
reviewed
Mar 31, 2026
Contributor
VDubber
left a comment
VDubber
left a comment
There was a problem hiding this comment.
Concerns:
- adds complexity to SDK
- adds memory consumption
- A layer of caching is already implemented via localGraphObjectStore
- time consuming to roll out and monitor for increased memory usage.
- We already have an established pattern to move away from findEntity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findEntity()for disk-resident entities reads and parses an entire JSON chunk file (~500 entities) on every call with no cachingFileSystemGraphObjectStore.findEntity()flushEntitiesToDisk()to prevent stale readsTest plan
🤖 Generated with Claude Code