[deepseek_v4] performance: use coli_v4_route_bf16 in moe_token - #1017
Open
weber-software wants to merge 1 commit into
Open
[deepseek_v4] performance: use coli_v4_route_bf16 in moe_token#1017weber-software wants to merge 1 commit into
weber-software wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I have let deepseek_v4-flash optimize its own engine. And it found something:
I have tested the performance with multiple runs:
Without the optimization it takes ~13 seconds and with the optimization ~11 seconds (AMD Ryzen 9 3900X 12-Core Processor, 64GB DDR4).
I have deleted the coli_usage before every run and made sure that the experts are in OS cache (single token + enough free memory).
I also tested the generation of longer texts and compared them (with/without the optimization) and they had the same output. I do not cite them because they contained much more time generating (and i think the optimization is only for prefill?).
Validation
make -C c checkmake -C c cuda-test(if applicable)Compatibility
Disclaimer
deepseek_v4-flash has done the work and i'm unsure if my validations are correct. So please check them yourself too.