fix(mirror): recognize Kimi K3 expert shards - #1028
Open
terrizoaguimor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
block_sparse_moeexpert naming schemew1,w2, andw3without double-countingw1.weight_packedas K3's replica anchor while preserving GLM'sgate_proj.weightbehaviorWhy
coli mirror plancurrently recognizes only GLM-stylemlp.experts.*.{gate,up,down}_proj.weighttensors. A Kimi K3 checkpoint therefore produces no usage-ranked shards even with valid.coli_usagehistory. This is the planner-only first step requested in #812; the K3 runtime still does not consume a mirror, and this PR intentionally does not close the issue.Testing
PYTHONDONTWRITEBYTECODE=1 python3 -m unittest -v tests.test_mirror_planmake check(473 Python tests passed, 59 skipped, plus the C suite)git diff --checkRefs #812