fix(ci): add gateway test step and remove silent Python install fallback#3
Open
deensaleh wants to merge 1 commit into
Open
Conversation
Two CI gaps that let failures go undetected: Bug 1 — gateway-mcp has 170 tests but CI never ran them. The gateway job built the package but had no Test step. Policy engine tests, bypass attack tests, classifier tests, anomaly detection tests — all 170 were completely invisible to CI. Silent regressions in security-critical code could ship undetected. Fix: add 'npm test' step after the build step in the gateway job. All 170 tests pass. Bug 2 — Python SDK install swallowed errors silently. 'pip install -e ".[dev]" 2>/dev/null || pip install -e .' hides real installation failures. If [dev] extras fail for a legitimate reason (missing dep, version conflict), the fallback masks it and CI reports success on a broken install. Fix: use 'pip install -e ".[dev]"' directly. The dev extras install cleanly — agentguard-core-schema is published on PyPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI gaps that let failures go undetected:
Bug 1 — gateway-mcp has 170 tests but CI never ran them. The gateway job built the package but had no Test step. Policy engine tests, bypass attack tests, classifier tests, anomaly detection tests — all 170 were completely invisible to CI. Silent regressions in security-critical code could ship undetected.
Fix: add 'npm test' step after the build step in the gateway job. All 170 tests pass.
Bug 2 — Python SDK install swallowed errors silently. 'pip install -e ".[dev]" 2>/dev/null || pip install -e .' hides real installation failures. If [dev] extras fail for a legitimate reason (missing dep, version conflict), the fallback masks it and CI reports success on a broken install.
Fix: use 'pip install -e ".[dev]"' directly. The dev extras install cleanly — agentguard-core-schema is published on PyPI.