Skip to content

Reentrancy guard needed around on_selectDeviceDialog() (ported from AntScope2 PR#29) -- already present #28

Description

@K4HEZ

Ported from reviewing rigexpert/AntScope2#29 for applicability here (review-only pass).

Upstream: rigexpert/AntScope2#29

The bug (upstream): on_selectDeviceDialog() runs a nested event loop via dlg.exec(), during which a pending QTimer::singleShot call to the same slot could in principle stack a second dialog on top of the first.

Status in AntScopeZ (checked 2026-09-08): already present, and more thoroughly documented. src/mainwindow_analyzer.cpp:251-280 (MainWindow::on_selectDeviceDialog()) already guards with an m_selectDeviceDialogOpen member flag, with an extensive comment explaining exactly this race (two independent triggers -- Settings' "Connect analyzer" button and the startup auto-reconnect fallback -- that could otherwise stack two instances), and why QApplication::activeModalWidget() alone isn't sufficient here. No action needed. Closing for the record.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingupstream-reviewPorted from reviewing rigexpert/AntScope2's issues/PRs

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions