Skip to content

Touchstone (.s2p) import not case-insensitive for unit tokens (ported from AntScope2#6 / PR#7) -- already fixed #32

Description

@K4HEZ

Ported from reviewing rigexpert/AntScope2#6 (and its fix, PR#7) for applicability here (review-only pass).

Upstream: rigexpert/AntScope2#6, fixed by rigexpert/AntScope2#7

The bug (upstream): touchstone import fails if the option line's unit tokens aren't in the exact expected case (e.g. # Hz S RI R 50 works, # HZ S RI R 50 doesn't), despite the Touchstone spec stating files are case-insensitive.

Status in AntScopeZ (checked 2026-09-08): already fixed, and more thoroughly than upstream's own fix. src/measurements_io.cpp:683 uppercases the entire line before parsing (line = line.toUpper();), and all the unit/parameter comparisons (GHZ/MHZ/KHZ/HZ/S/etc., lines 694-710+) are already written against the uppercase form. No action needed. Closing for the record.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingupstream-reviewPorted from reviewing rigexpert/AntScope2's issues/PRs

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions