fix: prevent double on_choice invocation in picker - #28
Open
KEY60228 wants to merge 1 commit into
Open
Conversation
Closing the picker window fires BufLeave, whose scheduled cancel ran even after a confirm had already closed the picker — so on_choice was invoked twice: first with nil, then with the selected item. All current callers happen to nil-guard, but this violates the vim.ui.select-style contract the picker advertises. Guard cancel() with the closed flag so only the path that actually closes the picker reports a result. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closing the picker window fires
BufLeave, whose scheduledcancelran even after a confirm had already closed the picker — soon_choicewas invoked twice: first withnil, then with the selected item. All current callers happen to nil-guard, so no visible breakage yet, but this violates thevim.ui.select-style contract the picker advertises and becomes a real bug the moment a caller does cleanup on thenilpath.Guards
cancel()with the existingclosedflag so only the path that actually closes the picker reports a result.Test plan
Headless-nvim test against the real picker module, all three paths now invoke
on_choiceexactly once:<CR>→[itemA](was[nil, itemA]before the fix)q→[nil][nil]🤖 Generated with Claude Code