fix: notify when an empty comment is confirmed - #31
Open
KEY60228 wants to merge 1 commit into
Open
Conversation
Confirming the comment input with no text (e.g. clearing a comment while editing) was silently treated as a cancel, giving no hint about whether anything was saved. Emit a warning so the outcome is visible. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Confirming the comment input with no text (e.g. clearing a comment while editing it) was silently treated as a cancel, giving no hint about whether anything was saved. Now a warning ("Empty comment discarded.") is emitted so the outcome is visible; the cancel semantics are unchanged.
Test plan
Code-reviewed branch addition; behavior unchanged except the added
vim.notifyon the empty-text path.🤖 Generated with Claude Code