feat: make --user optional in password set/clear, use imap.user from config - #28
Merged
Merged
Conversation
…config - args: --user optional (default None) for password set and clear - __main__: resolve user from args.user or cfg imap.user; error if neither - tests: missing-user, imap.user fallback, parse without --user - README: Quick Start and Password Management mention optional --user Fixes #27
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Remove 'smtp.example.com' substring check (py/incomplete-url-substring-sanitization) - Add permissions to CI and build-and-publish workflows (actions/missing-workflow-permissions) - Add redact_email, use in auth/smtp/fetcher logs (py/clear-text-logging-sensitive-data)
11 tasks
- Quick Start: install module only (no .venv), split First Run into Fetch + Send - Remove Features & Improvements / v7.1 Features block (duplicate of Key Features)
…older - send folder: dir and --to optional, use smtp.send_folder / default_recipient from config - send without subcommand defaults to send folder with config - README: fetch/send use config by default, document 'send' and 'send folder' - Tests: send_folder missing dir/to, parse send no args, send-without-subcommand integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make
--useroptional forpassword setandpassword clear. When omitted, useimap.userfrom config. Error if neither--usernorimap.useris available.Closes #27
Type of Change
Related Issue
Closes #27
Changes Made
--useroptional forpassword set/password clear; fallback toimap.userfrom config; error if neither.dirand--tooptional; fallback tosmtp.send_folderandsmtp.default_recipientfrom config.python -m email_processor senddefaults tosend folderwith config.sendandsend folderdocumented; Features block removed.redact_emailfor logs.Testing
Checklist
pre-commit run --all-files)ruff format --check .)ruff check .)Additional Notes
--userstill overridesimap.userwhen both are present.fetchandsenduse config by default;send= send from folder (config).