Conversation
Release-please ran as `github-actions[bot]`, and bot-authored commits put their workflow runs into `action_required` with zero jobs created. `ci` is a required status check, so the release PR sat BLOCKED with an empty `statusCheckRollup` until someone approved the runs by hand — which is what happened to #100, and to the integration's release PR four times over (KRoperUK/dimplex-controller-hass#200). The workflow now uses `secrets.RELEASE_PLEASE_TOKEN` when it is defined and falls back to the default token otherwise, so this is safe to merge before the secret exists and nothing changes for anyone who does not add one. CONTRIBUTING says what to create and why. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
Owner
Author
|
Closing this: the token approach is not wanted — release-please runs are triggered and approved deliberately when a release is wanted, so there is no need for a PAT here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release-please runs as
github-actions[bot], and bot-authored commits put their workflow runs intoaction_requiredwith zero jobs created.ciis a required status check, so the release PR satBLOCKEDwith an emptystatusCheckRollupuntil someone approved the runs by hand — which is what happened to #100, and to the integration's release PR four times over (KRoperUK/dimplex-controller-hass#200).The workflow now uses
secrets.RELEASE_PLEASE_TOKENwhen it is defined and falls back to the default token otherwise, so this is safe to merge before the secret exists and nothing changes for anyone who does not add one.CONTRIBUTING.mdsays what to create and why.Refs KRoperUK/dimplex-controller-hass#200.
Type of change
Checklist
ruff check .passesruff format --check .passesmypypasses — the config isstrict(no library code changed; run anyway)pytestpasses (196 tests, no library code changed)docs/where relevantBehaviour changes worth calling out
None to the library. The workflow keeps working exactly as it does today until
RELEASE_PLEASE_TOKENis added, at which point release PRs stop needing manual run approval.actionlintis clean, andpre-commit run --all-filespasses.