Adds QueryProcessor to separate queries from Controllers#106
Open
Adds QueryProcessor to separate queries from Controllers#106
Conversation
Contributor
Author
|
Thanks @jakemco I'll fix the conflict manually later and rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

By separating out the queries from the controllers we should be able to start writing unit tests over the controllers and passing in a dummy query processor that we can check to see if a particular query was run when we needed it without having to run the query and set-up a KTContext etc.
I've used a simple static singleton to retrieve the QueryProcessor each time. Ideally we'd move this to an IoC container eventually. For now it serves it's possible.
Next step is to do something similar with the CommandHandlers so we don't need to pass in each one every time.