Port points calculations to rust#190
Open
samayala22 wants to merge 26 commits into
Open
Conversation
AlphaKeks
requested changes
May 9, 2026
AlphaKeks
requested changes
May 11, 2026
AlphaKeks
requested changes
May 14, 2026
AlphaKeks
left a comment
Collaborator
There was a problem hiding this comment.
Looks mostly good now! Because there's new query macros, you'll have to run cargo sqlx prepare --workspace -- --all-features from the repo root to update the .sqlx/ directory. Those files are used for compile-time query checking when no actual database is available (such as in CI). After that I'll approve a CI run.
I'll also check this against the production dataset later tonight to make sure the results look similar enough, and that perf is good.
AlphaKeks
reviewed
May 15, 2026
Author
|
Have you checked against the production dataset yet ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported all the points calculation logic to be in-process and in pure Rust.
Validation was done in 2 phases:
Avg point difference (excluding outliers due to sus outdated fitting data in the api): 30 (3% difference).