docs: add ADRs for React wrappers, slots-vs-props, distribution, and runtime deps#775
Merged
Conversation
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pixelflips
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to the ADR work in the sibling ds-tokens repo. Pine already has ADRs 0001–0005; this adds four more for long-lived decisions that shape the codebase but weren't written down anywhere — the kind that get re-litigated when someone new asks "why is it like this?".
New ADRs
@pine-ds/reactis a separately-published, generated package depending on core, and the lockstep-versioning cost.<slot>s; thepds-button.iconprop is deprecated toward thestartslot). Documents why content goes in slots, so it isn't re-decided per component.@pine-ds/core/@kajabi-ui/stylesmust be kept in sync (the consuming ERB even says so).@floating-ui/domfor overlays; DOMPurify for sanitizing consumer-supplied option markup inpds-combobox. Flags DOMPurify as load-bearing security — removing it reintroduces XSS.Verification
Every claim checked against the code, not memory:
reactOutputTargetinstencil.config.ts;@pine-ds/reactdeps on@pine-ds/core ^3.26.4.<slot>;icon@deprecated→startslot confirmed.main/module/unpkg/collection/loader entry points inpackage.json.@floating-ui/domin combobox/multiselect/tooltip util;DOMPurify.sanitizeinpds-combobox'ssanitizeHtml.Type of change
How Has This Been Tested?
Checklist:
Note
Low Risk
Documentation-only; no runtime, build, or dependency changes.
Overview
Adds four retrospective architecture decision records (0006–0009) and extends
docs/adr/README.mdso the index covers 0001–0009 instead of 0001–0005.0006 documents generated
@pine-ds/reactvia Stencil’sreactOutputTargetand lockstep publishing with@pine-ds/core. 0007 codifies “props for configuration, slots for content” (includingpds-buttonicon→startslot) and points to sanitization in 0009. 0008 records dual npm + jsDelivr CDN distribution with a lazy loader and the manual CDN pin / core–styles version sync requirement. 0009 records@floating-ui/domfor overlays and DOMPurify inpds-comboboxas load-bearing XSS defense when rendering consumer HTML.No application or build code changes—documentation and cross-references only.
Reviewed by Cursor Bugbot for commit fbbad0b. Bugbot is set up for automated code reviews on this repo. Configure here.