chore: fix global CODEOWNERS pattern and route to current maintainers#776
Open
QuintonJason wants to merge 1 commit into
Open
chore: fix global CODEOWNERS pattern and route to current maintainers#776QuintonJason wants to merge 1 commit into
QuintonJason wants to merge 1 commit into
Conversation
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two things, both maintenance for the incoming-contributor phase now that the DSS team has wound down:
Fixes a latent bug. The global-owners line was
- @Kajabi/dss-devs. In CODEOWNERS, patterns are gitignore-style —*matches all files, but a bare-matches only a file literally named-. GitHub doesn't flag it (it's syntactically valid), but it means no code-owner review has actually been required on general files — only/.github/(owned by PE) had a working rule. Changed to*.Routes to the real maintainers.
@Kajabi/dss-devsis a dissolved team (2 remaining members). Points ownership at the two people actually maintaining Pine now — @QuintonJason and @pixelflips — so the review gate survives the team being deleted.The
/.github/ @kajabi/production-engineeringrule is unchanged.Type of change
How Has This Been Tested?
GET /repos/Kajabi/pine/codeowners/errors(no syntax errors) and confirmed@QuintonJason/@pixelflipsare the twodss-devsmembers with write access.Checklist:
Note
Low Risk
Repository review-policy only; no application code, auth, or runtime behavior changes.
Overview
Fixes the global CODEOWNERS rule so it actually applies to the whole repo: the old pattern
-only matched a file named-, so required reviews were not enforced on normal paths (only/.github/via production-engineering still worked). The rule is now*, with owners switched from dissolved@Kajabi/dss-devsto @QuintonJason and @pixelflips, plus a short comment documenting the bug and maintainer handoff.The
/.github/ @kajabi/production-engineeringline is unchanged.Reviewed by Cursor Bugbot for commit 30f9af0. Bugbot is set up for automated code reviews on this repo. Configure here.