feat(trend-reports): make HTML report consume full page width#1
Open
Kalindi-Dev wants to merge 1 commit intomainfrom
Open
feat(trend-reports): make HTML report consume full page width#1Kalindi-Dev wants to merge 1 commit intomainfrom
Kalindi-Dev wants to merge 1 commit intomainfrom
Conversation
Remove the max-width: 1200px constraint from the body CSS so the trend HTML report expands to fill the entire browser viewport width. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Task-Id: 59dea93c15f2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-width: 1200pxCSS constraint from thebodyelement in the trend HTML report renderermargin: 0 autotomargin: 0so the report now fills the entire browser viewport widthtrend-report.htmlfile to reflect the same changeChanges
File:
scripts/aidlc-evaluator/packages/trend-reports/src/trend_reports/render_html.pybodyCSS: removedmax-width: 1200px; margin: 0 auto→ replaced withmargin: 0File:
scripts/aidlc-evaluator/packages/trend-reports/examples/trend-report.htmlBuild and test results
uv run pytest packages/trend-reports/tests/ -v→ 145 passed, 1 warning ✅uv run ruff check packages/trend-reports/) → 1 pre-existing error (qual_statusunused variable inrender_html.py:240, unrelated to this change) — was already failing before this PRDecisions made
The only constraint limiting the report width was
max-width: 1200pxon thebodyelement. Removing it (along with the centeringmargin: 0 auto) allows the report to span the full viewport. The responsive breakpoint at 768px and all other layout CSS remain unchanged.Agent notes
What went well: The change was minimal and precise — one CSS property to remove. The codebase has good test coverage (145 tests) and the change was validated quickly.
What was difficult:
mise run buildandmise run lintdidn't work from the repo root (no tasks defined there); the actual tools areuv run pytestanduv run rufffromscripts/aidlc-evaluator/.Patterns/conventions discovered:
uvfor Python dependency management with a workspace structure underscripts/aidlc-evaluator/render_html.py— no external stylesheet filesexamples/trend-report.htmlis a pre-generated snapshot that needs to stay in sync withrender_html.pySuggestions for future tasks:
mise run buildtask in the repo root that delegates touvcommandsqual_statuslint warning inrender_html.py:240should be cleaned upBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.