Skip to content

Fix union types #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KanishkNavale merged 2 commits into from
Jun 3, 2026
Merged

Fix union types #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47ef583
Deps: Updated
KanishkNavale Jun 3, 2026
b62ce8c
Fix: allow union-all restriction
KanishkNavale Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 58 additions & 20 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions src/patterns/definitions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,9 @@ impl PatternEntry {

/// Dialect-agnostic SQL injection patterns applicable to any relational database.
pub const GENERAL: &[PatternEntry] = &[
// UNION-based exfiltration — column-count probing to read arbitrary rows.
// UNION-based injection — appends attacker-controlled SELECT to combine results
PatternEntry::new(
r"(?i)\bunion\b(?:\s+(?:all|distinct))?\s+select\b",
r"(?i)\bunion\b\s+select\b",
&[CWE::CWE89],
&[CWE::CWE200],
&[66],
Expand Down Expand Up @@ -260,9 +260,8 @@ pub const GENERAL: &[PatternEntry] = &[
&[CWE::CWE208, CWE::CWE400],
&[7],
),
// CASE-based blind injection — conditional branching leaks data through query behaviour.
PatternEntry::new(
r"(?i)\bcase\s+when\s+.+?\s+then\b",
r"(?i)\bcase\s+when\s+\(?\s*select\b",
&[CWE::CWE89],
&[CWE::CWE208],
&[7],
Expand Down
2 changes: 2 additions & 0 deletions tests/test_main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ static SHOULD_PASS: &[&str] = &[
"SELECT * FROM users WHERE id = 1",
"SELECT id, name FROM users WHERE status = 'active'",
"SELECT COUNT(*) FROM orders WHERE created_at > '2024-01-01'",
"SELECT COUNT(*) AS total FROM cve_feed UNION ALL SELECT COUNT(*) AS total FROM oid_feed",
"SELECT SUM(CASE WHEN feed = 'enterprise' THEN 1 ELSE 0 END) AS c FROM oid_feed WHERE feed IS NOT NULL UNION ALL SELECT SUM(CASE WHEN feed = 'enterprise' THEN 1 ELSE 0 END) AS c FROM cve_feed WHERE feed IS NOT NULL",
];

#[test]
Expand Down
Loading
Loading