fix(install-env): patch PyFoam vendored six.py for Python 3.12+#827
Open
yehudarav wants to merge 1 commit into
Open
fix(install-env): patch PyFoam vendored six.py for Python 3.12+#827yehudarav wants to merge 1 commit into
yehudarav wants to merge 1 commit into
Conversation
PyFoam 2023.7 ships six.py v1.10 (2016), whose _SixMetaPathImporter trick no longer works under Python 3.12's tightened import machinery, breaking `from PyFoam.ThirdParty.six.moves import configparser`. Overwrite the vendored copy with the venv's modern six during install so the fix is reproducible across clean environments. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
six.py(v1.10) whose_SixMetaPathImportertrick breaks on Python 3.12+, sofrom PyFoam.ThirdParty.six.moves import configparserfails.pip install,set_hera_environment.shnow overwrites PyFoam's vendoredsix.pywith the venv's modernsix(v1.17+), restoring the import.sixorPyFoam.ThirdPartyis missing, so older Python versions and partial installs are unaffected.Test plan
source set_hera_environment.sh— verifypython -c "from PyFoam.ThirdParty.six.moves import configparser"succeeds.🤖 Generated with Claude Code