Upgrade BouncyCastle#4
Draft
steinybot wants to merge 1 commit into
Draft
Conversation
steinybot
force-pushed
the
upgrade-bouncycastle
branch
from
54b452e to
45d11d8
Compare
Author
|
This is a draft as it depends on #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades the library to use BouncyCastle 1.6.x and the new TLS API (the old one was deprecated and is now gone).
It might be worthwhile changing some of the type aliases in
com.karasiq.tls.TLS. It's a bit annoying converting between the 4 different certificate types. I'm not even sure that it works correctly.