perf(zero-cache): negotiate cumulative stream acks - #10
Closed
Karavil wants to merge 1 commit into
Closed
Conversation
Why: reduce websocket ACK churn while keeping new clients compatible with old v6 stream servers during rollout. * advertise cumulative ACK capability before enabling cumulative sender semantics * make new clients fall back to per-message ACKs without the capability frame * add benchmark ACK mode controls for cumulative websocket runs
Karavil
force-pushed
the
capy/rm-vs-load-v6-websocket-batches
branch
from
May 26, 2026 19:02
4a4431c to
9ca34bf
Compare
Karavil
force-pushed
the
capy/rm-vs-load-cumulative-ack-negotiation
branch
from
May 26, 2026 19:02
053ba29 to
2dd5827
Compare
Owner
Author
|
Replaced by rocicorp/mono PRs rocicorp#6070 through rocicorp#6078. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
Adds negotiated cumulative ACKs for the stream transport. New clients request cumulative ACKs, but only enable them after the server sends the capability frame. Old v6 servers therefore keep receiving per-message ACKs.
benchmark output
medium-wide-batch-pressure, 15s, compared to v6 websocket batch frames:validation