perf(zero-cache): improve rm fanout flow control - #7
Closed
Karavil wants to merge 1 commit into
Closed
Conversation
Why: let the RM keep the serving apply pipeline full without waiting for every slow subscriber on every small byte window * release flow control after subscriber majority plus padding * batch forwarded changes before subscriber fanout * widen the bounded fanout byte window used by the benchmark
Karavil
force-pushed
the
capy/rm-vs-load-serving-local-apply
branch
from
May 26, 2026 19:02
0d0e9ec to
8b7d6ce
Compare
Karavil
force-pushed
the
capy/rm-vs-load-fanout-flow
branch
from
May 26, 2026 19:02
d68c8d6 to
4e5e06e
Compare
Owner
Author
|
Replaced by rocicorp/mono PRs rocicorp#6070 through rocicorp#6078. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
Raises the RM fanout byte window, batches forwarded changes, and lets flow control release after majority completion plus padding.
Also fixes the split branch ordering issue found by benchmark: a subscriber batch now enqueues the whole batch synchronously before awaiting results, so later fire-and-forget batches cannot interleave before a prior commit.
benchmark output
Targeted 16-subscriber websocket run,
medium-wide-batch-pressure, 15s, apply disabled:The single-consumer stack run is roughly neutral to noisy for this PR, which matches the intent. This change is about RM fanout pressure across multiple serving replicas.
validation