Skip to content

Conversation

@Drodt
Copy link
Member

@Drodt Drodt commented Feb 20, 2025

Related Issue

This pull request fixes #3563.

Intended Change

Add a new taclet equalityOfSingleton, which resolves singleton(o1, f1) = singleton(o2, f2) to o1 = o2 & f1 = f2.

Type of pull request

  • There are changes to the taclet rule base

Ensuring quality

  • I have tested the feature as follows: Proven the taclet sound.

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@Drodt
Copy link
Member Author

Drodt commented Feb 20, 2025

This PR is the result of #3565 at the 2025 HacKeYthon.
Thanks to @frereit et al.

@mattulbrich
Copy link
Member

mattulbrich commented Feb 20, 2025

If it is proven, the taclet should be marked as \lemma such that the correctness proof becomes part of the CI tests.

@Drodt
Copy link
Member Author

Drodt commented Feb 20, 2025

So that's what lemma does! Interesting.

@Drodt
Copy link
Member Author

Drodt commented Feb 20, 2025

The error is the same merge rule that fails on #3543 but it fails on ubuntu, not Windows.

@mattulbrich
Copy link
Member

The error is the same merge rule that fails on #3543 but it fails on ubuntu, not Windows.

I assume that this is a "heisenbug". It might have to do with the order in which branches are traversed. It's my conjecture since the merge rules spans over several branches unlike most other rules.

@mattulbrich mattulbrich added this pull request to the merge queue Feb 22, 2025
Merged via the queue into main with commit dfc5b50 Feb 22, 2025
7 checks passed
@mattulbrich mattulbrich deleted the fix-3563 branch February 22, 2025 12:43
@WolframPfeifer WolframPfeifer moved this from In Progress to Done in 3rd HacKeYthon Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Automatic solver fail to proceed with two equal set singletons

3 participants