feat(web): migrate settings, sidebar, banners and toasts to the provider layer - #3383
Open
tyler-dane wants to merge 8 commits into
Open
feat(web): migrate settings, sidebar, banners and toasts to the provider layer#3383tyler-dane wants to merge 8 commits into
tyler-dane wants to merge 8 commits into
Conversation
Add generic begin/disconnect/refresh routes, wrap begin as a redirect union, emit CONNECTION_REVOKED next to GOOGLE_REVOKED, and expose connections[] with provider while keeping metadata.google overlap. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Keep PROVIDER_NOT_CONFIGURED on the connection begin path from ever constructing a sync client. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Introduce useConnectProvider, shared config availability, and provider-neutral connect-status toasts. useConnectGoogle becomes a google wrapper so existing spies and tests stay unchanged. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
…te-consumers-cc19 Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
…der layer Settings, calendar list, banners and reconnect toasts now read metadata.connections[] and name the connection's provider. Google copy stays byte-identical; Microsoft reconnect copy uses Outlook. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
marked this pull request as ready for review
September 5, 2026 01:29
tyler-dane
added
the
agent-automerge
Cursor
tyler-dane
enabled auto-merge
September 5, 2026 01:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3232
What and why
First consumer batch of the provider connect layer. Settings, the sidebar calendar list, connection banners, pointer hints, and reconnect/delayed toasts now read
metadata.connections[]and take the provider from the connection they render. A chooser lists every provider withconnectavailability; a single provider keeps today's one-click Add account / Connect Google Calendar path. Google strings stay byte-identical; Microsoft reconnect copy uses Outlook (Outlook needs reconnecting.).Verify
VERDICT: PASS
Checks run: test:web, type-check, lint, knip, test:a11y, test:e2e