fix(web): create events on the selected week column - #3388
Merged
Conversation
On another week, C always seeded the draft on the first visible day, and the timed form has no date field, so the draft was stuck there. Selecting a column with Shift+letter did not help: jump mode swallowed C, and an empty column could not be selected at all. One target-day rule now serves every Week create gesture (C, Shift+C, Shift+Arrow place, typed digits): parked click, then the selected column, then the focused event's day, then today, then the first visible day. Creating spends the selection so chips never linger over the new draft. Any visible column can be selected, with or without events, which also makes the header's Shift+letter chip true for empty days. createTimedDraft and createAlldayDraft take the target day directly, so Week no longer threads isCurrentWeek into the shortcut owner. The bus resubscribes when the event set changes because the create handlers now depend on the focused-event lookup; harmless. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
tyler-dane
marked this pull request as ready for review
September 5, 2026 13:50
tyler-dane
enabled auto-merge
September 5, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On another week,
Calways seeded the timed draft on the first visible day, and the timed form has no date field, so the draft was stuck there. Selecting a column with Shift+letter did not help: jump mode swallowedC, and a column with no events could not be selected at all.C,Shift+C, Shift+Arrow place-create, typed digits): parked click, then the selected column, then the focused event's day, then today, then the first visible day. Creating spends the selection so chips never linger over the new draft.H), with or without events. That also makes the⇧Theader chip true for empty days.createTimedDraft/createAlldayDrafttake the target day directly; Week no longer threadsisCurrentWeekinto the shortcut owner. Day view passes its date in view.docs/acceptance/shortcuts.mdScenario 5 and 12 plus the regression list.Behavior change worth knowing: on the current week,
Cwith a focused event now creates on that event's day, matching typed-time create since #3078.Verification
bun type-check,bun run lint,bun knip: clean.bun testfiles (matcher, jump hook, draft util, Week owner, Day grid, tips): all pass, including new cases for empty-column selection,Cpassthrough in jump mode, and Shift+R thenC/Shift+C/ Shift+Arrow landing on an empty Thursday.e2e/timed/shift-hold-event-hints.spec.ts: next window, Shift+letter on the last column,C, save, assert the weekday. Passes locally with the other jump-hint and grid-parity specs.Copens the form with the draft in Thursday and clears the highlight; Shift+T then1400places a 2 PM draft on Tuesday;HthenWmoves the hour chips to Wednesday; Shift+R thenShift+Cseeds an all-day draft on Thursday.bun run verify --strictlocally:VERDICT: FAIL. The failures are the documented macOS-only Playwright environment issues (Settings shortcut never opens on Mac, and the port 9150 test server dying mid-run withpage.gototimeouts and connection refused). The affected grid specs pass in isolation against a hand-started server. CI on Linux is the arbiter.🤖 Generated with Claude Code
Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com