Skip to content

test(e2e): wait for the slot picker before public booking tests start #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyler-dane merged 1 commit into from
Sep 5, 2026
+15 −0
Merged

test(e2e): wait for the slot picker before public booking tests start #3409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions e2e/booking/booking-harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,21 @@ export async function preparePublicBookingPage(
await expect(
page.getByRole("heading", { name: "Book with Tyler Dane" }),
).toBeVisible({ timeout: 15000 });
// The h1 renders before the slots request settles, and while slots are
// pending the picker shows a skeleton without the "Pick a time" heading.
// A test that starts typing right away (Tab to the skip link, Enter) would
// race that request: the skip link finds no target and focus goes nowhere.
// Wait for the picker itself unless the test is deliberately observing the
// pending, failed, or unavailable state.
if (
options.bookable !== false &&
!options.slotFailGate &&
!options.holdFirstSlots
) {
await expect(
page.getByRole("heading", { name: "Pick a time" }),
).toBeVisible();
}

return captured;
}
Expand Down